Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): extract messages from js and ts files #17673

Merged
merged 1 commit into from
Dec 8, 2021
Merged

fix(translations): extract messages from js and ts files #17673

merged 1 commit into from
Dec 8, 2021

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Dec 7, 2021

SUMMARY

TESTING INSTRUCTIONS

Run ./scripts/babel_extract.sh. The output lists files with js and ts suffixes

ADDITIONAL INFORMATION

  • Has associated issue: fixes babel.cfg omits js and ts files #17672
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #17673 (7d2b0dc) into master (e660ea2) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17673      +/-   ##
==========================================
+ Coverage   68.85%   68.92%   +0.06%     
==========================================
  Files        1598     1598              
  Lines       65250    65248       -2     
  Branches     6950     6950              
==========================================
+ Hits        44929    44973      +44     
+ Misses      18436    18390      -46     
  Partials     1885     1885
Flag Coverage Δ
hive 81.70% <ø> (+<0.01%) ⬆️
mysql 82.11% <ø> (+<0.01%) ⬆️
postgres 82.12% <ø> (+<0.01%) ⬆️
presto 81.99% <ø> (?)
python 82.61% <ø> (+0.15%) ⬆️
sqlite 81.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.34%) ⬆️
superset/utils/network.py 37.93% <0.00%> (+2.44%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e660ea2...7d2b0dc. Read the comment docs.

zhaoyongjie
zhaoyongjie approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@zhaoyongjie zhaoyongjie merged commit 3350076 into apache:master Dec 8, 2021
@hbruch hbruch mentioned this pull request Dec 8, 2021
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel.cfg omits js and ts files
3 participants
@hbruch @zhaoyongjie @mistercrunch